fix: Remove the use of Custom types #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakul1010
changed the base branch from
master
to
nakul/fix_remove_node_dependency
nakul1010
force-pushed
the
nakul/fix_rm_subxt_utils
branch
from
39e2e98
to
b63a927
Compare
…into nakul/fix_rm_subxt_utils # Conflicts: # runtime/src/tests.rs
nakul1010
added
ReviewNeeded
sander2
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493
The PR adds the following
sp_core::crypto::AccountId32instead of hardcoding the account id & implements the require traits